openclaw/CHFS-NG
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: match CHFS create-only overwrite semantics

Browse Source
This commit is contained in:
OpenClaw Agent
2026-09-21 22:02:20 +08:00
parent ece101edd7
commit 024c887d96
1 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chfs-ng/internal/api/server.go
+29 -6
View File
@@ -302,10 +302,10 @@ func (s *Server) rename(w http.ResponseWriter, r *http.Request) {
} }
if old != neu { if old != neu {
if _, e := s.Store.Stat(neu); e == nil { if _, e := s.Store.Stat(neu); e == nil {
if e := checkDeleteTree(s.Store, a, neu); e != nil { // CHFS rename is create-only: an existing destination is rejected
writeJSONError(w, http.StatusForbidden, "has no privilege") // rather than overwritten, even when the caller has delete access.
return writeJSONError(w, http.StatusBadRequest, "invalid parameter")
} return
} else if !os.IsNotExist(e) { } else if !os.IsNotExist(e) {
http.Error(w, e.Error(), 500) http.Error(w, e.Error(), 500)
return return
@@ -453,6 +453,13 @@ func (s *Server) newtext(w http.ResponseWriter, r *http.Request) {
return return
} }
p := path.Join(dir, filename) p := path.Join(dir, filename)
if _, e := s.Store.Stat(p); e == nil {
writeJSONError(w, http.StatusBadRequest, "invalid parameter")
return
} else if !os.IsNotExist(e) {
http.Error(w, e.Error(), 500)
return
}
if !a.MaskFor(p).HasWrite() { if !a.MaskFor(p).HasWrite() {
writeJSONError(w, http.StatusForbidden, "has no privilege") writeJSONError(w, http.StatusForbidden, "has no privilege")
return return
@@ -518,7 +525,15 @@ func (s *Server) upload(w http.ResponseWriter, r *http.Request) {
http.Error(w, "invalid filename", 400) http.Error(w, "invalid filename", 400)
return return
} }
if e := savePart(s.Store, path.Join(dir, name), h); e != nil { target := path.Join(dir, name)
if _, e := s.Store.Stat(target); e == nil {
writeJSONError(w, http.StatusBadRequest, "invalid parameter")
return
} else if !os.IsNotExist(e) {
http.Error(w, e.Error(), 500)
return
}
if e := savePart(s.Store, target, h); e != nil {
http.Error(w, e.Error(), 500) http.Error(w, e.Error(), 500)
return return
} }
@@ -570,7 +585,15 @@ func (s *Server) upload2(w http.ResponseWriter, r *http.Request) {
http.Error(w, "invalid filename", 400) http.Error(w, "invalid filename", 400)
return return
} }
if err := savePart(s.Store, path.Join(dir, name), h); err != nil { target := path.Join(dir, name)
if _, e := s.Store.Stat(target); e == nil {
writeJSONError(w, http.StatusBadRequest, "invalid parameter")
return
} else if !os.IsNotExist(e) {
http.Error(w, e.Error(), 500)
return
}
if err := savePart(s.Store, target, h); err != nil {
http.Error(w, err.Error(), 500) http.Error(w, err.Error(), 500)
return return
} }